<p>Sorry, hoped to work on this earlier but didn't have time in the last two days (will address the issues hopefully today).</p>
<blockquote>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=793526" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/b4n">@b4n</a> <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=713965" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/techee">@techee</a> I used the asciidoc.c from upstream ctags on top of this PR (and changed the map_ASCIIDOC in tm_parser.c to match) IT WORKS!!!! <g-emoji class="g-emoji" alias="1st_place_medal" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f947.png">🥇</g-emoji> <g-emoji class="g-emoji" alias="grinning" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f600.png">😀</g-emoji></p>
</blockquote>
<p>Cool! If it's the case (I haven't checked yet), I'd suggest using the upstream versions and if there's a better way to implement this, then we could go the (hopefully new standard) "implement in uctags, import to Geany" way. <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=793526" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/b4n">@b4n</a> What do you think?</p>
<blockquote>
<p>So all we have to do is merge this quickly and import the upstream <g-emoji class="g-emoji" alias="smile" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f604.png">😄</g-emoji> (well and <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=793526" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/b4n">@b4n</a> make the change to tm_parser.c properly).</p>
</blockquote>
<p>And even more cool thing is having <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=811085" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/elextr">@elextr</a> excited to get this merged into Geany soon :-).</p>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=793526" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/b4n">@b4n</a> Is it necessary to have a separate fix for master if it gets fixed in this branch? Master is mildly broken because of this now but it's not something super-critical like a crash and I think it could wait until this pull request is merged.</p>
<blockquote>
<p>why the TxtToTags cases are removed? or t2t isn't Txt2Tags?</p>
</blockquote>
<p>Ah, OK, the test got broken and without checking I somehow assumed it was Actionscript. Seems there's a problem with scope separators in this test - I'll look into this.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2018#issuecomment-449084804">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ3R0OBqr_DfoeCMNCew9pxjRfq6iks5u69CFgaJpZM4ZXOnd">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ9gfmDSbH2e4a5SBJsyULsR_HLFcks5u69CFgaJpZM4ZXOnd.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@techee in #2018: Sorry, hoped to work on this earlier but didn't have time in the last two days (will address the issues hopefully today).\r\n\r\n\u003e @b4n @techee I used the asciidoc.c from upstream ctags on top of this PR (and changed the map_ASCIIDOC in tm_parser.c to match) IT WORKS!!!! 🥇 😀\r\n\r\nCool! If it's the case (I haven't checked yet), I'd suggest using the upstream versions and if there's a better way to implement this, then we could go the (hopefully new standard) \"implement in uctags, import to Geany\" way. @b4n What do you think?\r\n\r\n\u003e So all we have to do is merge this quickly and import the upstream 😄 (well and @b4n make the change to tm_parser.c properly).\r\n\r\nAnd even more cool thing is having @elextr excited to get this merged into Geany soon :-).\r\n\r\n@b4n Is it necessary to have a separate fix for master if it gets fixed in this branch? Master is mildly broken because of this now but it's not something super-critical like a crash and I think it could wait until this pull request is merged.\r\n\r\n\u003e why the TxtToTags cases are removed? or t2t isn't Txt2Tags?\r\n\r\nAh, OK, the test got broken and without checking I somehow assumed it was Actionscript. Seems there's a problem with scope separators in this test - I'll look into this."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/2018#issuecomment-449084804"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2018#issuecomment-449084804",
"url": "https://github.com/geany/geany/pull/2018#issuecomment-449084804",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>