[Github-comments] [geany/geany] WIP: Fix reST and Asciidoc parser scope (#2019)

elextr notifications at xxxxx
Tue Dec 18 09:22:02 UTC 2018


@b4n from uctags `asciidoc.c`

```
		if (parent && (parent->kindIndex < kind))
		{
			/*
			 * This doesn't use Cork, but in this case I think this is better,
			 * because Cork would record the scopes of all parents in the chain
			 * which is weird for text section identifiers, and also this is
			 * what the rst.c reStructuredText parser does.
			 */
			e.extensionFields.scopeKindIndex = parent->kindIndex;
			e.extensionFields.scopeName = parent->name;
		}
```

Hence my question, why are you doing something different, why not just put the original back since its in upstream?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2019#issuecomment-448152479
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20181218/7329b55c/attachment.html>


More information about the Github-comments mailing list