<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=793526" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/b4n">@b4n</a> from uctags <code>asciidoc.c</code></p>
<pre><code>         if (parent && (parent->kindIndex < kind))
                {
                        /*
                         * This doesn't use Cork, but in this case I think this is better,
                         * because Cork would record the scopes of all parents in the chain
                         * which is weird for text section identifiers, and also this is
                         * what the rst.c reStructuredText parser does.
                         */
                        e.extensionFields.scopeKindIndex = parent->kindIndex;
                        e.extensionFields.scopeName = parent->name;
                }
</code></pre>
<p>Hence my question, why are you doing something different, why not just put the original back since its in upstream?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2019#issuecomment-448152479">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ8ot57NtgXHG6PLvX2pmkkzQXW2Sks5u6LO6gaJpZM4ZXxvS">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABDrJ-0S3anrKfhnVfvBpJIZoydLaYCNks5u6LO6gaJpZM4ZXxvS.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@elextr in #2019: @b4n from uctags `asciidoc.c`\r\n\r\n```\r\n\t\tif (parent \u0026\u0026 (parent-\u003ekindIndex \u003c kind))\r\n\t\t{\r\n\t\t\t/*\r\n\t\t\t * This doesn't use Cork, but in this case I think this is better,\r\n\t\t\t * because Cork would record the scopes of all parents in the chain\r\n\t\t\t * which is weird for text section identifiers, and also this is\r\n\t\t\t * what the rst.c reStructuredText parser does.\r\n\t\t\t */\r\n\t\t\te.extensionFields.scopeKindIndex = parent-\u003ekindIndex;\r\n\t\t\te.extensionFields.scopeName = parent-\u003ename;\r\n\t\t}\r\n```\r\n\r\nHence my question, why are you doing something different, why not just put the original back since its in upstream?"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/2019#issuecomment-448152479"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2019#issuecomment-448152479",
"url": "https://github.com/geany/geany/pull/2019#issuecomment-448152479",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>