[Github-comments] [geany/geany-plugins] Improve/fix some things related to the utils library (#631)

Colomban Wendling notifications at xxxxx
Mon Oct 16 07:18:24 UTC 2017


Most importantly IMO, add a prefix (C "namespace") to functions from that lib.  Let's not do the same mistake as Geany there.

2 additional things that could be nice:
1. install header files so it can be used by 3rd parties as well
2. build some developer documentation (I kind of hate Doxygen for its total lack of automated main page, but we could use that nonetheless like Geany does)
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany-plugins/pull/631

-- Commit Summary --

  * Only automatically enable the utils library if a plugin uses it
  * Fix building the utils library on Windows
  * utils: Put public functions in the "gp" namespace
  * utils: Small code style cleanup
  * utils: Add C++ guards

-- File Changes --

    M Makefile.am (3)
    M build/utils.m4 (39)
    M build/workbench.m4 (1)
    M configure.ac (3)
    M utils/src/Makefile.am (2)
    M utils/src/filelist.c (17)
    M utils/src/filelist.h (12)
    M workbench/src/wb_project.c (2)

-- Patch Links --

https://github.com/geany/geany-plugins/pull/631.patch
https://github.com/geany/geany-plugins/pull/631.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/631
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20171016/d2e5040d/attachment.html>


More information about the Github-comments mailing list