<p>Most importantly IMO, add a prefix (C "namespace") to functions from that lib.  Let's not do the same mistake as Geany there.</p>
<p>2 additional things that could be nice:</p>
<ol>
<li>install header files so it can be used by 3rd parties as well</li>
<li>build some developer documentation (I kind of hate Doxygen for its total lack of automated main page, but we could use that nonetheless like Geany does)</li>
</ol>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/geany/geany-plugins/pull/631'>https://github.com/geany/geany-plugins/pull/631</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Only automatically enable the utils library if a plugin uses it</li>
  <li>Fix building the utils library on Windows</li>
  <li>utils: Put public functions in the "gp" namespace</li>
  <li>utils: Small code style cleanup</li>
  <li>utils: Add C++ guards</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany-plugins/pull/631/files#diff-0">Makefile.am</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany-plugins/pull/631/files#diff-1">build/utils.m4</a>
    (39)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany-plugins/pull/631/files#diff-2">build/workbench.m4</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany-plugins/pull/631/files#diff-3">configure.ac</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany-plugins/pull/631/files#diff-4">utils/src/Makefile.am</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany-plugins/pull/631/files#diff-5">utils/src/filelist.c</a>
    (17)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany-plugins/pull/631/files#diff-6">utils/src/filelist.h</a>
    (12)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany-plugins/pull/631/files#diff-7">workbench/src/wb_project.c</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/geany/geany-plugins/pull/631.patch'>https://github.com/geany/geany-plugins/pull/631.patch</a></li>
  <li><a href='https://github.com/geany/geany-plugins/pull/631.diff'>https://github.com/geany/geany-plugins/pull/631.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/631">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ_CRgNAxONB9JvNygZS5mrBIwLjvks5sswNAgaJpZM4P6LdB">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ74jgvSBMdqAffd3kOYkbdLNhKa_ks5sswNAgaJpZM4P6LdB.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany-plugins/pull/631"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Improve/fix some things related to the utils library (#631)"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany-plugins/pull/631"}}}</script>