[Github-comments] [geany/geany-plugins] addons/markword: Deselect when the selection changes (#614)

[Enrico Tröger]

eht16 commented on this pull request.

Looks good and seems reasonable, except for the comment.

> @@ -190,6 +208,14 @@ void ao_mark_document_open(AoMarkWord *mw, GeanyDocument *document)
 		FALSE,
 		G_CALLBACK(on_editor_button_press_event),
 		mw);
+		
+	plugin_signal_connect(

This is the wrong place for the signal connect.
Here we connect to the signal on each opened document but never disconnect from it.

It would be better to re-use the already existing signal callback `ao_editor_notify_cb` in addons.c and add there a call to `on_editor_notify` after making it public.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/614#pullrequestreview-67533335
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20171005/5e32b673/attachment.html>