<p><b>@eht16</b> commented on this pull request.</p>

<p>Looks good and seems reasonable, except for the comment.</p><hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/614#discussion_r143073695">addons/src/ao_markword.c</a>:</p>
<pre style='color:#555'>> @@ -190,6 +208,14 @@ void ao_mark_document_open(AoMarkWord *mw, GeanyDocument *document)
                FALSE,
                G_CALLBACK(on_editor_button_press_event),
                mw);
+               
+       plugin_signal_connect(
</pre>
<p>This is the wrong place for the signal connect.<br>
Here we connect to the signal on each opened document but never disconnect from it.</p>
<p>It would be better to re-use the already existing signal callback <code>ao_editor_notify_cb</code> in addons.c and add there a call to <code>on_editor_notify</code> after making it public.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/614#pullrequestreview-67533335">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJwx-XtroQlPhCz2A-GWHhp3zIr63ks5spVk2gaJpZM4PuQgx">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ3JNry9-fLiYNQLSN4FCDu573GEhks5spVk2gaJpZM4PuQgx.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany-plugins/pull/614#pullrequestreview-67533335"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@eht16 commented on #614"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany-plugins/pull/614#pullrequestreview-67533335"}}}</script>