[Github-comments] [geany/geany] Push current position to navqueue before navigating back (#1537)

elextr notifications at xxxxx
Sat Jul 15 06:04:41 UTC 2017


@kugel-  NULL `doc` is only prevented from something hidden in the context, in this case UI sensitivity.  The `doc` pointer may be NULL and yes you are correct, the `doc->file_name` can be NULL.

Geany is nowhere near exhaustively tested to be able to have some reasonable guarantee that asserts will not be hit by users, so we should not be inserting crashers like assert in the code.  Just provide a message if you must using the Glib logging capability that is already set up in Geany, but otherwise the original `if(doc && doc->file_name)` is file.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1537#issuecomment-315512679
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20170714/06ae8ea8/attachment.html>


More information about the Github-comments mailing list