<p><a href="https://github.com/kugel-" class="user-mention">@kugel-</a>  NULL <code>doc</code> is only prevented from something hidden in the context, in this case UI sensitivity.  The <code>doc</code> pointer may be NULL and yes you are correct, the <code>doc->file_name</code> can be NULL.</p>
<p>Geany is nowhere near exhaustively tested to be able to have some reasonable guarantee that asserts will not be hit by users, so we should not be inserting crashers like assert in the code.  Just provide a message if you must using the Glib logging capability that is already set up in Geany, but otherwise the original <code>if(doc && doc->file_name)</code> is file.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1537#issuecomment-315512679">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ2SbyUGRppNSZLP38WlYsbaB5tRNks5sOFZ5gaJpZM4OR0zM">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ01S-5kUICNuQkMMjYp-N0Imvy1jks5sOFZ5gaJpZM4OR0zM.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1537#issuecomment-315512679"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@elextr in #1537: @kugel-  NULL `doc` is only prevented from something hidden in the context, in this case UI sensitivity.  The `doc` pointer may be NULL and yes you are correct, the `doc-\u003efile_name` can be NULL.\r\n\r\nGeany is nowhere near exhaustively tested to be able to have some reasonable guarantee that asserts will not be hit by users, so we should not be inserting crashers like assert in the code.  Just provide a message if you must using the Glib logging capability that is already set up in Geany, but otherwise the original `if(doc \u0026\u0026 doc-\u003efile_name)` is file."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1537#issuecomment-315512679"}}}</script>