[Github-comments] [geany/geany] Avoid gdk_display_get_name() on OS X (#1399)

Colomban Wendling notifications at xxxxx
Mon Feb 20 13:45:33 UTC 2017


b4n commented on this pull request.



> @@ -284,8 +284,15 @@ gint socket_init(gint argc, gchar **argv)
 	GdkDisplay *display = gdk_display_get_default();
 	gchar *p;
 
+	/* On OS X with quartz backend gdk_display_get_name() returns hostname
+	 * using [NSHost currentHost] (it could return more or less whatever string
+	 * as display name is a X11 specific thing). This call can lead to network
+	 * query and block for several seconds so better skip it. */
+#ifndef GDK_WINDOWING_QUARTZ

maybe under Quartz it doesn't matter, but shouldn't this be guarded by `if (GDK_IS_QUARTZ_DISPLAY (display))` to support a build combining X11 and Quartz?

```C
#ifdef GDK_WINDOWING_QUARTZ
	if (display != NULL && GDK_IS_QUARTZ_DISPLAY (display))
		; /* nothing */
	else
#endif
	if (display != NULL)
		...
```
Or a prettier variation around this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1399#pullrequestreview-22762975
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20170220/1a3fec85/attachment.html>


More information about the Github-comments mailing list