<p><b>@b4n</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1399#discussion_r102020387">src/socket.c</a>:</p>
<pre style='color:#555'>> @@ -284,8 +284,15 @@ gint socket_init(gint argc, gchar **argv)
        GdkDisplay *display = gdk_display_get_default();
        gchar *p;
 
+       /* On OS X with quartz backend gdk_display_get_name() returns hostname
+        * using [NSHost currentHost] (it could return more or less whatever string
+        * as display name is a X11 specific thing). This call can lead to network
+        * query and block for several seconds so better skip it. */
+#ifndef GDK_WINDOWING_QUARTZ
</pre>
<p>maybe under Quartz it doesn't matter, but shouldn't this be guarded by <code>if (GDK_IS_QUARTZ_DISPLAY (display))</code> to support a build combining X11 and Quartz?</p>
<div class="highlight highlight-source-c"><pre>#<span class="pl-k">ifdef</span> GDK_WINDOWING_QUARTZ
        <span class="pl-k">if</span> (display != <span class="pl-c1">NULL</span> && GDK_IS_QUARTZ_DISPLAY (display))
                ; <span class="pl-c"><span class="pl-c">/*</span> nothing <span class="pl-c">*/</span></span>
        <span class="pl-k">else</span>
#<span class="pl-k">endif</span>
        <span class="pl-k">if</span> (display != <span class="pl-c1">NULL</span>)
                ...</pre></div>
<p>Or a prettier variation around this.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1399#pullrequestreview-22762975">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ3NlrpuTQjHy95bh8mRNM6MDzQJ1ks5reZj9gaJpZM4MC29v">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ8q12O2eQpqGmg0MEjwWNI8ldGskks5reZj9gaJpZM4MC29v.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1399#pullrequestreview-22762975"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n commented on #1399"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1399#pullrequestreview-22762975"}}}</script>