[Github-comments] [geany/geany] Always emit the project-save signal when writing project file (#1400)

Colomban Wendling notifications at xxxxx
Mon Feb 20 13:31:05 UTC 2017


b4n requested changes on this pull request.

Apart from my pickyness, I don't see why not emitting this signal either, and this change shouldn't lead to logic issues in plugins.
So LGBI minus the prototype thing.

> @@ -83,7 +83,7 @@ typedef struct _PropertyDialogElements
 static gboolean update_config(const PropertyDialogElements *e, gboolean new_project);
 static void on_file_save_button_clicked(GtkButton *button, PropertyDialogElements *e);
 static gboolean load_config(const gchar *filename);
-static gboolean write_config(gboolean emit_signal);
+static gboolean write_config();

C prototype!!  `(void)`

>   * Returns: TRUE if project file was written successfully. */
-static gboolean write_config(gboolean emit_signal)
+static gboolean write_config()

ditto

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1400#pullrequestreview-22759723
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20170220/7560a821/attachment.html>


More information about the Github-comments mailing list