<p><b>@b4n</b> requested changes on this pull request.</p>

<p>Apart from my pickyness, I don't see why not emitting this signal either, and this change shouldn't lead to logic issues in plugins.<br>
So LGBI minus the prototype thing.</p><hr>

<p>In <a href="https://github.com/geany/geany/pull/1400#discussion_r102017269">src/project.c</a>:</p>
<pre style='color:#555'>> @@ -83,7 +83,7 @@ typedef struct _PropertyDialogElements
 static gboolean update_config(const PropertyDialogElements *e, gboolean new_project);
 static void on_file_save_button_clicked(GtkButton *button, PropertyDialogElements *e);
 static gboolean load_config(const gchar *filename);
-static gboolean write_config(gboolean emit_signal);
+static gboolean write_config();
</pre>
<p>C prototype!!  <code>(void)</code></p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1400#discussion_r102017321">src/project.c</a>:</p>
<pre style='color:#555'>>   * Returns: TRUE if project file was written successfully. */
-static gboolean write_config(gboolean emit_signal)
+static gboolean write_config()
</pre>
<p>ditto</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1400#pullrequestreview-22759723">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ6Vx70r2uD8-yIvR5XKh-eeu7VqUks5reZWZgaJpZM4MFGGL">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ6SEU8TPBTs0VJm-5OGaNGDlR4A9ks5reZWZgaJpZM4MFGGL.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1400#pullrequestreview-22759723"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n requested changes on #1400"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1400#pullrequestreview-22759723"}}}</script>