[Github-comments] [geany/geany-plugins] some proposes to fix issue #656 (#656)

[Colomban Wendling]

b4n requested changes on this pull request.

Looks close, but for GTK2 support

> @@ -49,8 +49,8 @@ AC_DEFUN([GP_CHECK_MARKDOWN],
     GTK_VERSION=2.16
     WEBKIT_VERSION=1.1.13
 
-    GP_CHECK_GTK3([webkit_package=webkitgtk-3.0],
-                  [webkit_package=webkit-1.0])
+    GP_CHECK_GTK3([webkit_package=webkit2gtk-4.0],
+                    [webkit_package=webkit2gtk-4.0])

This won't work for a GTK2 Geany: webkit2gtk is just not available for GTK2

> @@ -300,7 +300,7 @@ static void
 on_webview_load_status_notify(WebKitWebView *view, GParamSpec *pspec,
   MarkdownViewer *self)
 {
-  WebKitLoadStatus load_status;
+  WebKitLoadEvent load_status;
 
   g_object_get(view, "load-status", &load_status, NULL);

[webkit2gtk web view](https://webkitgtk.org/reference/webkit2gtk/stable/WebKitWebView.html) doesn't ave a `load-status` property.

this should be replaced with [`load-changed`](https://webkitgtk.org/reference/webkit2gtk/stable/WebKitWebView.html#WebKitWebView-load-changed) and/or [`load-failed`](https://webkitgtk.org/reference/webkit2gtk/stable/WebKitWebView.html#WebKitWebView-load-failed) handlers.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/656#pullrequestreview-82318108
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20171208/89e2b7e4/attachment.html>