<p><b>@b4n</b> requested changes on this pull request.</p>

<p>Looks close, but for GTK2 support</p><hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/656#discussion_r155914711">build/markdown.m4</a>:</p>
<pre style='color:#555'>> @@ -49,8 +49,8 @@ AC_DEFUN([GP_CHECK_MARKDOWN],
     GTK_VERSION=2.16
     WEBKIT_VERSION=1.1.13
 
-    GP_CHECK_GTK3([webkit_package=webkitgtk-3.0],
-                  [webkit_package=webkit-1.0])
+    GP_CHECK_GTK3([webkit_package=webkit2gtk-4.0],
+                    [webkit_package=webkit2gtk-4.0])
</pre>
<p>This won't work for a GTK2 Geany: webkit2gtk is just not available for GTK2</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/656#discussion_r155914780">markdown/src/viewer.c</a>:</p>
<pre style='color:#555'>> @@ -300,7 +300,7 @@ static void
 on_webview_load_status_notify(WebKitWebView *view, GParamSpec *pspec,
   MarkdownViewer *self)
 {
-  WebKitLoadStatus load_status;
+  WebKitLoadEvent load_status;
 
   g_object_get(view, "load-status", &load_status, NULL);
</pre>
<p><a href="https://webkitgtk.org/reference/webkit2gtk/stable/WebKitWebView.html" rel="nofollow">webkit2gtk web view</a> doesn't ave a <code>load-status</code> property.</p>
<p>this should be replaced with <a href="https://webkitgtk.org/reference/webkit2gtk/stable/WebKitWebView.html#WebKitWebView-load-changed" rel="nofollow"><code>load-changed</code></a> and/or <a href="https://webkitgtk.org/reference/webkit2gtk/stable/WebKitWebView.html#WebKitWebView-load-failed" rel="nofollow"><code>load-failed</code></a> handlers.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/656#pullrequestreview-82318108">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ-CzxokpFdcnYue9PW3lZy4na7cEks5s-itfgaJpZM4Q74OD">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ0My42_6R8rmJr4YFwLx3sJtvnnkks5s-itfgaJpZM4Q74OD.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany-plugins/pull/656#pullrequestreview-82318108"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany-plugins","title":"geany/geany-plugins","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany-plugins"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n requested changes on #656"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany-plugins/pull/656#pullrequestreview-82318108"}}}</script>