[Github-comments] [geany/geany] Add support for platform-specific keybindings (#1395)

[Colomban Wendling]

b4n requested changes on this pull request.



> @@ -782,6 +768,36 @@ static void load_kb(GeanyKeyGroup *group, GeanyKeyBinding *kb, gpointer user_dat
 }
 
 
+static void init_platform_kb(void)
+{
+#ifdef __APPLE__
+	gchar *configfile = g_build_filename(app->datadir, "keybindings_osx.conf", NULL);

why loading a platform-named file instead of simply `keybindings.conf`, and install a different one (or none) depending on the platform? I mean, it doesn't make any sense to have an OSX keybinding file on Windows or GNU/Linux, nor it would to have a Windows one on OSX, etc.  Plus, it would make it easier to have specific keybindings on non-OSX in the future if wanted, without having to actually change the loading code.

The only "trick" would be to install an OSX-specific file on OSX, which should be reasonably easy to do.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1395#pullrequestreview-55914019
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20170811/1ca990e9/attachment.html>