<p><b>@b4n</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1395#discussion_r132789693">src/keybindings.c</a>:</p>
<pre style='color:#555'>> @@ -782,6 +768,36 @@ static void load_kb(GeanyKeyGroup *group, GeanyKeyBinding *kb, gpointer user_dat
 }
 
 
+static void init_platform_kb(void)
+{
+#ifdef __APPLE__
+       gchar *configfile = g_build_filename(app->datadir, "keybindings_osx.conf", NULL);
</pre>
<p>why loading a platform-named file instead of simply <code>keybindings.conf</code>, and install a different one (or none) depending on the platform? I mean, it doesn't make any sense to have an OSX keybinding file on Windows or GNU/Linux, nor it would to have a Windows one on OSX, etc.  Plus, it would make it easier to have specific keybindings on non-OSX in the future if wanted, without having to actually change the loading code.</p>
<p>The only "trick" would be to install an OSX-specific file on OSX, which should be reasonably easy to do.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1395#pullrequestreview-55914019">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJws_rhAfvQ8GDSnqlLuXQZUC8ZjKks5sXMwCgaJpZM4MB2vq">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ-11Rid0lKqoTAauKVeedHni_5YTks5sXMwCgaJpZM4MB2vq.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1395#pullrequestreview-55914019"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n requested changes on #1395"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1395#pullrequestreview-55914019"}}}</script>