[Github-comments] [geany/geany] Emit project-close before destroying project (#1235)

Colomban Wendling notifications at xxxxx
Sun Oct 23 14:56:30 UTC 2016


Hum, didn't I comment on this?

Looks mostly good, but for the part where a plugin might want to react to that signal to restore the non-project values, in which case Geany still behaving like a project is open might be problematic.
I don't think plugins from GP would currently suffer from that, but show knows.  For example Project Organizer checks for the Geany project there, but fortunately it also check for its internal project pointer which is reset to NULL just before, but it's close to affect it.

So maybe we should have a `project-before-close` signal instead, although it ain't so pretty.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1235#issuecomment-255593184
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20161023/836d2eb8/attachment.html>


More information about the Github-comments mailing list