<p>Hum, didn't I comment on this?</p>

<p>Looks mostly good, but for the part where a plugin might want to react to that signal to restore the non-project values, in which case Geany still behaving like a project is open might be problematic.<br>
I don't think plugins from GP would currently suffer from that, but show knows.  For example Project Organizer checks for the Geany project there, but fortunately it also check for its internal project pointer which is reset to NULL just before, but it's close to affect it.</p>

<p>So maybe we should have a <code>project-before-close</code> signal instead, although it ain't so pretty.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1235#issuecomment-255593184">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ4SjHvK4ubVURDXZmI5nrvGcs_A2ks5q23WegaJpZM4J_3Kg">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ29ANIOnYE7pSBKdjC6afwtRWfbeks5q23WegaJpZM4J_3Kg.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1235#issuecomment-255593184"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@b4n in #1235: Hum, didn't I comment on this?\r\n\r\nLooks mostly good, but for the part where a plugin might want to react to that signal to restore the non-project values, in which case Geany still behaving like a project is open might be problematic.\r\nI don't think plugins from GP would currently suffer from that, but show knows.  For example Project Organizer checks for the Geany project there, but fortunately it also check for its internal project pointer which is reset to NULL just before, but it's close to affect it.\r\n\r\nSo maybe we should have a `project-before-close` signal instead, although it ain't so pretty."}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1235#issuecomment-255593184"}}}</script>