[Github-comments] [geany/geany] Re-enable SIGTERM handling (#1255)

[elextr]

elextr commented on this pull request.



>  		main_quit();
 	}
+	return G_SOURCE_REMOVE;

If Geany ever returns to the main loop during the quit (which at least GIO file saves would do I think) then you should remove it to avoid getting it again.  But if you are going to allow multiple signals in the one handler then you may want to continue and then you need code to filter that signal out since you don't want to re-enter `main_quit()` or *bad things* will happen.  There is already a quitting global you could use for that :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1255
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20161005/8c90331e/attachment.html>