<p><b>@elextr</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1255">src/libmain.c</a>:</p>
<pre style='color:#555'>>              main_quit();
        }
+       return G_SOURCE_REMOVE;
</pre>
<p>If Geany ever returns to the main loop during the quit (which at least GIO file saves would do I think) then you should remove it to avoid getting it again.  But if you are going to allow multiple signals in the one handler then you may want to continue and then you need code to filter that signal out since you don't want to re-enter <code>main_quit()</code> or <em>bad things</em> will happen.  There is already a quitting global you could use for that :)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1255">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJyYcUfJ82vx3YC7m8qGf4PjPEqt9ks5qxDMggaJpZM4KPCgU">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ7I9mr6yS-IkpJyHX3aCB9KPVTTRks5qxDMggaJpZM4KPCgU.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1255"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@elextr commented on #1255"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1255"}}}</script>