[Github-comments] [geany/geany] Re-enable SIGTERM handling (#1255)

[Matthew Brush]

codebrainz commented on this pull request.



>  {
+	gint sig = GPOINTER_TO_INT(user_data);
 	if (sig == SIGTERM)

The idea was to make it like a normal signal handler, and since any future handlers are likely going to do something similar, or at least something small/simple, it seemed good to keep all the handling in one place.

At this point it would be cleaner not to pass the signal and just have it `sigterm_handler()` but I intend to submit a pull request "soon" to handle `SIGINT` so the config gets saved when using <kbd>Ctrl</kbd>+<kbd>C</kbd> from the terminal, in which case it's a mere matter of adding `|| sig == SIGINT` in the handler and another call to `g_unix_signal_add()` for `SIGINT`.

If you want, I can change it for now though, and then re-evaluate the code when there's more than one signal.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1255
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20161005/4327c462/attachment.html>