<p><b>@codebrainz</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/1255">src/libmain.c</a>:</p>
<pre style='color:#555'>>  {
+       gint sig = GPOINTER_TO_INT(user_data);
        if (sig == SIGTERM)
</pre>
<p>The idea was to make it like a normal signal handler, and since any future handlers are likely going to do something similar, or at least something small/simple, it seemed good to keep all the handling in one place.</p>

<p>At this point it would be cleaner not to pass the signal and just have it <code>sigterm_handler()</code> but I intend to submit a pull request "soon" to handle <code>SIGINT</code> so the config gets saved when using <kbd>Ctrl</kbd>+<kbd>C</kbd> from the terminal, in which case it's a mere matter of adding <code>|| sig == SIGINT</code> in the handler and another call to <code>g_unix_signal_add()</code> for <code>SIGINT</code>.</p>

<p>If you want, I can change it for now though, and then re-evaluate the code when there's more than one signal.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1255">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ-fcrdo0gwylt1PxXCBYA9iQd4Wnks5qxCRjgaJpZM4KPCgU">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ6aCrK_hFIhyBY9GY8JcHp56-maqks5qxCRjgaJpZM4KPCgU.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1255"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@codebrainz commented on #1255"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1255"}}}</script>