[Github-comments] [geany/geany] TM cleanups (#957)

[Jiří Techet]

> +{
> +	TMParserMap *map = &parser_map[lang];
> +	guint i;
> +
> +	for (i = 0; i < map->size; i++)
> +	{
> +		TMParserMapEntry *entry = &map->entries[i];
> +
> +		if (entry->type == type)
> +			return entry->kind;
> +	}
> +	return '-';
> +}
> +
> +
> +void tm_parser_verify_type_mappings(void)

I'm just wondering whether all the return value propagation is necessary - if we call g_error() instead of g_warning() everywhere, it should guarantee the process terminates with a non-0 exit code and the patch shouldn't be necessary. Or do I miss something?

And thanks a lot for all the patches - I went through them quickly and they look great.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/957/files/aea7d7845917843dd6b02e5a8dc9031cabc87a86..5d9376ea801a6e6c3ec22748741362a3a2eff7ac#r62088088
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160504/c514bad9/attachment.html>