<p>In <a href="https://github.com/geany/geany/pull/957#discussion_r62088088">tagmanager/src/tm_parser.c</a>:</p>
<pre style='color:#555'>> +{
> +  TMParserMap *map = &parser_map[lang];
> +  guint i;
> +
> +  for (i = 0; i < map->size; i++)
> +  {
> +          TMParserMapEntry *entry = &map->entries[i];
> +
> +          if (entry->type == type)
> +                  return entry->kind;
> +  }
> +  return '-';
> +}
> +
> +
> +void tm_parser_verify_type_mappings(void)
</pre>
<p>I'm just wondering whether all the return value propagation is necessary - if we call g_error() instead of g_warning() everywhere, it should guarantee the process terminates with a non-0 exit code and the patch shouldn't be necessary. Or do I miss something?</p>

<p>And thanks a lot for all the patches - I went through them quickly and they look great.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly or <a href="https://github.com/geany/geany/pull/957/files/aea7d7845917843dd6b02e5a8dc9031cabc87a86..5d9376ea801a6e6c3ec22748741362a3a2eff7ac#r62088088">view it on GitHub</a><img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ_HkOAwN9Bagd0esR-G9WGfDSbZRks5p-OKTgaJpZM4Ht-Ad.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/957/files/aea7d7845917843dd6b02e5a8dc9031cabc87a86..5d9376ea801a6e6c3ec22748741362a3a2eff7ac#r62088088"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>