[Github-comments] [geany/geany] Windows: Convert working directory to locale encoding before spawning commands (#1095)

[Colomban Wendling]

Hum, this looks to me like it's the wrong place.  All spawn code expects locale strings everywhere (apparently: no conversion is done at all), and changing that would break API -- and it's actually consistent across that module (yet, it should be documented).
Couldn't we convert the directory (and possibly other bits) before feeding it to `spawn_*()`?  Also, we probably need to do that in all cases (non-Windows too), as we use `g_spawn_*()` API there, and it requires arguments in locale encoding (GLib filename encoding actually, but that's locale but on Windows).

So if something's wrong I'd say it's the calling code, and the docs not being clear enough.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1095#issuecomment-228902506
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160627/2175e19e/attachment.html>