[Github-comments] [geany/geany] Windows: Convert working directory to locale encoding before spawning commands (#1095)

[Enrico Tröger]

This should fix the issue in #1076: builds command for files with non-ASCII characters in the path cannot be executed.

I'm not sure why we didn't notice this earlier, either nobody tested this (unlikely I think) or something has changed in the meantime.
Anyway, these both commits should fix it:
bac9b3a converts the working directory in Geany itself in order to be able to execute any command (Compile, Build, Run, ...) at all

3830347 add codepage mangling in the generated batch script for Build->Run. This is not nice but the best I could get. Ideas like converting the whole script into locale encoding and such didn't work at all :(.


N.B. as usual I missed the string freeze, this time really close :). Hence the commented code in bac9b3a which would introduce a new string otherwise. For now, we just "throw" the pure error message from `g_locale_from_utf8` instead of some context description around. I'll change this post-1.28.
You can view, comment on, or merge this pull request online at:

  https://github.com/geany/geany/pull/1095

-- Commit Summary --

  * Windows: Convert working directory into locale encoding before spawning commands
  * Windows: Change codepage for directory change in created batch run script

-- File Changes --

    M src/build.c (9)
    M src/spawn.c (22)
    M src/win32.c (12)
    M src/win32.h (2)

-- Patch Links --

https://github.com/geany/geany/pull/1095.patch
https://github.com/geany/geany/pull/1095.diff

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1095
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160627/6c94a829/attachment.html>