[Github-comments] [geany/geany] New tagmanager query module (#1187)

[Matthew Brush]

> Both suggestions aren't type-safe and not compatible to GI. I don't see why we should start playing tricks with type-unsafe functions now?

Well the `...` was a joke as suggested by the :) and the next sentence starting with "An actually sensible...". Putting a flags parameter isn't any more type unsafe than anything else in C, avoids having lots of boolean parameters, and allows you to customize the function further in the future by adding options that can be represented as flags.

> Unfortunately, it's referencing the whole array which causes the slow down.

The usual solution here is to write those parts of the Python code in an extension module. IMO adding a bunch of code to Geany to work around problems with Python/PyGI isn't a great solution.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1187#issuecomment-242371134
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160825/12be585e/attachment.html>