[Github-comments] [geany/geany] Change Save As->Rename to Save As->Save and Remove Original (#1190)

[konsolebox]

>  
>  	g_return_val_if_fail(!EMPTY(utf8_filename), FALSE);
>  
>  	if (doc->file_name != NULL)
>  	{
> -		if (rename_file)
> -		{
> -			document_rename_file(doc, utf8_filename);
> -		}
> +		if (remove_orig_file && strcmp(utf8_filename, doc->file_name) != 0)

Almost every part of the code treats it as UTF-8 (and converts it sometimes to current locale with `utils_get_locale_from_utf8`; e.g. `gchar *old_locale_filename = utils_get_locale_from_utf8(doc->file_name);`).  Or am I wrong?


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1190/files/4019f701838557b6e6dd419a4c8de59701f7d64c#r75998378
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160823/4bf2ce5a/attachment.html>