<p>In <a href="https://github.com/geany/geany/pull/1190#discussion_r75998378">src/dialogs.c</a>:</p>
<pre style='color:#555'>>  
>    g_return_val_if_fail(!EMPTY(utf8_filename), FALSE);
>  
>    if (doc->file_name != NULL)
>    {
> -          if (rename_file)
> -          {
> -                  document_rename_file(doc, utf8_filename);
> -          }
> +          if (remove_orig_file && strcmp(utf8_filename, doc->file_name) != 0)
</pre>
<p>Almost every part of the code treats it as UTF-8 (and converts it sometimes to current locale with <code>utils_get_locale_from_utf8</code>; e.g. <code>gchar *old_locale_filename = utils_get_locale_from_utf8(doc->file_name);</code>).  Or am I wrong?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1190/files/4019f701838557b6e6dd419a4c8de59701f7d64c#r75998378">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABDrJ7jRHroS2KdjGbVfTFxSkzMZ9HfLks5qi9zKgaJpZM4JrfCw">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJ_wF1xHpdLjymkApb5ZA4GIRarpCks5qi9zKgaJpZM4JrfCw.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/1190/files/4019f701838557b6e6dd419a4c8de59701f7d64c#r75998378"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/geany/geany","title":"geany/geany","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/geany/geany"}},"updates":{"snippets":[{"icon":"PERSON","message":"@konsolebox in #1190: Almost every part of the code treats it as UTF-8 (and converts it sometimes to current locale with `utils_get_locale_from_utf8`; e.g. `gchar *old_locale_filename = utils_get_locale_from_utf8(doc-\u003efile_name);`).  Or am I wrong?\r\n"}],"action":{"name":"View Pull Request","url":"https://github.com/geany/geany/pull/1190/files/4019f701838557b6e6dd419a4c8de59701f7d64c#r75998378"}}}</script>