[Github-comments] [geany] plugins: pass GModule * to geany_load_module() (#719)

[Colomban Wendling]

Makes some sense, although it would be technically possible to simply set `subplugin->priv->proxy_data = module` in `plugin_load_gmodule()` before calling `geany_load_module()`.

If we go the additional arg way like this (which seem mostly OK to me, see below), we need to document `plugin_module_make_resident()` doesn't work with new-style API in `load()`, and probably deprecate it.  Advertizing both functions depending on the call site seems overly odd to me.

However, most plugins probably only need to make the module resident after `init()` -- as `load()` will often not create `GType`s;  and if a lot of plugins end up being resident when loaded (and all installed plugins gets "loaded"), it might have a largish and unwanted memory impact.

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/719#issuecomment-152765257
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20151031/d44aaad9/attachment.html>