[Github-comments] [geany] plugins: pass GModule * to geany_load_module() (#719)
Thomas Martitz
notifications at xxxxx
Sat Oct 31 14:57:33 UTC 2015
This is rquired to enable the plugin to call g_module_make_resident() within
its geany_load_module(). This must be done if the plugin registers new
GTypes within that function.
plugin_module_make_resident() doesn't work because it's not an allowed API
function to call from there. Simply allowing it doesn't suffice because
internally the built-in plugin loader isn't fully set up yet:
plugin->proxy_data isn't set to the GModule at this point (by design), and
plugin_module_make_resident() requires that to be set.
This changes a public API, but it is unreleased so far, so not a problem (by
definition).
You can view, comment on, or merge this pull request online at:
https://github.com/geany/geany/pull/719
-- Commit Summary --
* plugins: pass GModule * to geany_load_module()
-- File Changes --
M plugins/demoplugin.c (2)
M plugins/demoproxy.c (2)
M src/plugindata.h (3)
M src/plugins.c (4)
-- Patch Links --
https://github.com/geany/geany/pull/719.patch
https://github.com/geany/geany/pull/719.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/719
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20151031/b1dfe12b/attachment.html>
More information about the Github-comments
mailing list