[Github-comments] [geany] Use g_return_val_if_fail() to fix build on OS X (#697)

[Thomas Martitz]

> @@ -2000,7 +2000,7 @@ gboolean geany_plugin_register_proxy(GeanyPlugin *plugin, const gchar **extensio
>  	foreach_list(node, active_proxies.head)
>  	{
>  		proxy = node->data;
> -		g_return_if_fail(p != proxy->plugin);
> +		g_return_val_if_fail(p != proxy->plugin, FALSE);

Registering twice is currently explicitly unsupported currently, so any attempt is a programming error (though a plugin error so an assert might not be ideal)

The plan is to enable it once the details are fleshed out and code is written, with the intention to enable proxies to change their list of supported files 

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/697/files#r42184135
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20151015/932d04da/attachment.html>