[Github-comments] [geany] Minor highlighting issues in C and Python (#748)

[Colomban Wendling]

> @b4n, since these are standard library types, shouldn't they should come from their respective tag files (`data/c99.tags` and `data/python.tags`) rather than hard-coding as language keywords?

For C, as @elextr forwarded.  If we want `bool` to appear as a type without altering the identifiers list, we'd need to have the code adding types from tags resolve macros -- which is, well, not easy to really do right.  And it wouldn't help for `true` and `false`, as they are just mere `1` and `0`.

For Python, I'm not sure… what is listed in `identifiers=` are `__builtins__`, but I believe they are also in `python.tags` -- though the ones from `python.tags` won't alter highlighting for some reason (well, because `HLKeyword::merge` is `FALSE` for Python's `identifiers`).

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/748#issuecomment-156162645
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20151112/5bc4bf49/attachment.html>