[Github-comments] [geany] Store "equal" tags into binary trees instead of lists in Symbol tree (#797)

[Colomban Wendling]

>  		}
> -		*list = g_list_prepend(*list, g_slice_dup(GtkTreeIter, iter));
> +
> +		gtk_tree_model_get(GTK_TREE_MODEL(store), iter, SYMBOLS_COLUMN_TAG, &tag, -1);

I don't like looking up the store if it can be avoided.  And IIUC it can, "just" needs to also receive the old tag as a second arg: in the first pass we already looked it up, and in the second it'll be the same.

---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/797/files#r48277009
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20151222/c57f3b4c/attachment.html>