<p>In <a href="https://github.com/geany/geany/pull/797#discussion_r48277009">src/symbols.c</a>:</p>
<pre style='color:#555'>>              }
> -          *list = g_list_prepend(*list, g_slice_dup(GtkTreeIter, iter));
> +
> +          gtk_tree_model_get(GTK_TREE_MODEL(store), iter, SYMBOLS_COLUMN_TAG, &tag, -1);
</pre>
<p>I don't like looking up the store if it can be avoided.  And IIUC it can, "just" needs to also receive the old tag as a second arg: in the first pass we already looked it up, and in the second it'll be the same.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>Reply to this email directly or <a href="https://github.com/geany/geany/pull/797/files#r48277009">view it on GitHub</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/ABDrJycG0--uG-J1mXExYgBhoBtoU4R1ks5pSYDvgaJpZM4G0Ju3.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/geany/geany/pull/797/files#r48277009"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>