[Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins
magnetudinbuda at xxxxx
Thu May 28 21:03:30 UTC 2015
I have read the source code of automark [ https://github.com/geany/geany-plugins/blob/master/automark/src/automark.c ].
Functionally, automark and GeanyHighlightSelectedWord are alike, I think. There are differences between automark
Automark is concise: it uses the SCI_FINDTEXT messages to scintilla for finding occurrences of selected text.
Automark uses a timeout callback for matching text.
GeanyHighlightSelectedText is more 'low-level': it does not use scintilla's SCI_FINDTEXT functionality, instead it
uses the KMP algorithm to find all occurrences of selected text in visible text. GeanyHighlightSelectedText does
not use timeout callback for matching text.
While the functionality may be the same, there were different decisions in the design of these two plugins. Let's
have both automark and GeanyHighlightSelectedText included in Geany Plugins.
If it is okay, I would continue with build system integration, and internationalization for GeanyHighlightSelectedWord.
This would be something I would code, and test locally, and when done I would return to ask for support on how to
do the git pull request step.
Have a great day,
Marius Ioan Buzea
On Thu, 5/28/15, Colomban Wendling <lists.ban at herbesfolles.org> wrote:
Subject: Re: [Geany-Devel] pull request on GitHub, to add GeanyHighlightSelectedWords, into Geany Plugins
To: "marius buzea" <magnetudinbuda at yahoo.com>, "Geany development list" <devel at lists.geany.org>
Date: Thursday, May 28, 2015, 12:21 AM
Le 27/05/2015 14:25, marius buzea a écrit :
> I would like to add
GeanyHighlightSelectedWords, to Geany Plugins.
> Would it be okay that I do a git
pull-request for doing this? […]
Sure. I see some other people suggested
already included plugins might
something similar, so I'll let you check whether you can
your efforts or not, but we
generally are happy including any plugin :)
(well, given it's of decent quality, but we can even
help with that if
we think something might
know there would be some things I would need to do before,
> replace the Makefile with
Makefile.am, the autotools, automake way,
> and write a README file using restructured
text content so that that
> README file
can be converted to html. Maybe there is more
> should be done.
It's pretty much it. Build
system integration, and internationalization
integration. But we can help with both, you
can read HACKING, and
is quite easy.
More information about the Devel