[Geany-Devel] f403e7e (PR#188) - Maintain edit history on document reload

[Lex Trotman]

On 25 June 2015 at 15:19, Thomas Martitz <kugel at rockbox.org> wrote:
> Am 25. Juni 2015 02:51:43 MESZ, schrieb Matthew Brush <mbrush at codebrainz.ca>:
>>On 2015-06-24 05:47 PM, Lex Trotman wrote:
>>> [...]
>>>
>>>> I wonder if there's a more simple way to reduce confusion and
>>increase visibility other than an annoying dialog or document message.
>>Maybe as a separate action with a different name in the edit menu?
>>>
>>> Menu, what menu? I use the toolbar button.  Changing the name won't
>>help here.
>>>
>>
>>Then maybe just having it keep the tab label red and asterisk in the
>>window title is enough. I think those would've been enough of a clue
>>for
>>me to figure out I could undo.
>>
>
> The red indicates that the buffer is changed and unsaved, in other words the buffer is not the same as the file on disk. So clearing it on reload is the right thing.

Well, thinking about it some more red doesn't really indicate anything
about the buffer matching the file, just add a character and delete
it, the buffer is the same as the disk, but it stays red.

What it indicates is that there have been edit actions since the last
file to buffer sync (save or reload).

>
> After saving, you the indication is also cleared *and* you can undo. That's been fine since forever.

Yes, having determined what red actually means, this makes sense and
having reload do it too is fine.

>
> I think a document message would be a fine way to transport this feature.
>
> "The file has been reloaded. You can revert the buffer to the previous state simply by undoing. This message will not be displayed again.
>
> This feature can be disabled by clicking "Always clear undo".

I assume this sets a setting that can be edited elsewhere, since only
allowing one shot at making such a decision is bad ("This message will
not be displayed again"), in which case its probably good to reference
that setting, whatever its going to be.

I still feel its overkill, but so long as its unobtrusive and doesn't
appear again I'm ok with it.

>
> [ Okay ]
> [ Always clear undo ]
> "
>
> Best regards

Somewhat OT, red is not the best choice for this since about 10% of
males have red colour vision deficiency, and most Geany users are
probably males.

>
>
> _______________________________________________
> Devel mailing list
> Devel at lists.geany.org
> https://lists.geany.org/cgi-bin/mailman/listinfo/devel