[Geany-Devel] The (mostly windows) spawning fix

Matthew Brush mbrush at xxxxx
Wed May 21 18:19:40 UTC 2014


On 14-05-21 11:02 AM, Dimitar Zhekov wrote:
> Hi,
>
> Now that Geany 1.24[.1] is out, will we apply $subject? [1] [2]
>
> [1] https://github.com/geany/geany/pull/274
> [2] http://sourceforge.net/p/geany/bugs/943/?page=3
>

I like it overall, and especially deleting 1000 lines of code :), 
although it's really massive - and so hard to review - since the whole 
thing is in one commit (maybe for good reason, I don't know).

One thing I couldn't figure out is why the Makefile.am and wscript (but 
not makefile.win32) adds files called spawn.[ch] but they don't show up 
in the commit/repo. Did you miss a `git add` command?

Cheers,
Matthew Brush


More information about the Devel mailing list