[Geany-Devel] Win32 color chooser dialog removal, concerning the Pull Request #215

Matthew Brush mbrush at xxxxx
Tue Mar 4 15:41:53 UTC 2014

On 14-03-04 06:57 AM, Steven VALSESIA wrote:
> Hi everybody !
> I copy-paste a code that belong to Peter Scholtens that add an apply button
> to the color chooser.
> But to make that code useful to windows users, and make the code more
> maintainable, I choose to remove the Win32 API window dialog and put the
> Gtk's one !

As long as it's not the new toy GTK3 dialog made for exclusively for 
smart phones, it's really really terrible.

> Does someone know why that dialog has been used for ?
> Does somebody feel that move disrespectful ? :P

IMO, it should follow the "use_win32_native_dialogs" (or whatever) 
preference at least, like the other native win32 dialogs. But, I see no 
point in completely removing it while leaving all the other win32 native 
dialogs in there, it seems kind of an arbitrary change.

Also the colour chooser should be in a plugin too IMO, not mixed-in to 
core code, but I guess that's a different subject :)

Matthew Brush

More information about the Devel mailing list