[Geany-Devel] [Geany-devel] [PATCH] File saving dialog behavior

[Colomban Wendling]

Le 03/05/2012 13:41, Quentin Glidic a écrit :
> Hello,

Hi,

> Attached a little patch concerning the file saving dialog.
> I may have missed some use cases, but it works on all cases mentioned in
> the commit message.
> 
> The main point is about the “Rename”, the unsaved file one (last
> commit message line) is a bonus.

I agree that "Open in new tab" shouldn't have precedence over "Rename".

However, I'm not completely sure about the change on "Open in new tab"
behavior, e.g. that it has no effect either when renaming or when the
file wasn't yet saved.  Upon rename, I agree it doesn't seem to make
much sense, because the original tab would become "orphaned", and would
show a "hey, I'm not found on disk!".  But I can imagine one would save
to file while keeping the unsaved buffer open (maybe to save it to
another file again later on) -- OK, I don't have such use-case myself.

So, on this subject, open question: what do other think?  I'm OK with
the proposed behavior, but as said I could understand somebody wanting
to keep "open in new tab" with unsaved files;  but if no one cares it
probably makes the thing more intuitive to remove it (e.g. no unsaved
file after save).


Anyway, the UI should reflect the behavior, e.g. the "Open in new tab"
checkbox should be sensitive only if it will be used (with your patch,
when doc->file_name != NULL).

Regards,
Colomban


PS: BTW, please stick to ASCII in commit messages :)