[Geany-Devel] [Geany-devel] [PATCH] File saving dialog behavior

[Lex Trotman]

I can't find the mail with the patch quickly so I havn't looked at it.

On 6 November 2012 02:02, Colomban Wendling <lists.ban at herbesfolles.org>wrote:

> Le 03/05/2012 13:41, Quentin Glidic a écrit :
> > Hello,
>
> Hi,
>
> > Attached a little patch concerning the file saving dialog.
> > I may have missed some use cases, but it works on all cases mentioned in
> > the commit message.
> >
> > The main point is about the “Rename†, the unsaved file one (last
> > commit message line) is a bonus.
>
> I agree that "Open in new tab" shouldn't have precedence over "Rename".
>
> However, I'm not completely sure about the change on "Open in new tab"
> behavior, e.g. that it has no effect either when renaming or when the
> file wasn't yet saved.  Upon rename, I agree it doesn't seem to make
> much sense, because the original tab would become "orphaned", and would
> show a "hey, I'm not found on disk!".  But I can imagine one would save
> to file while keeping the unsaved buffer open (maybe to save it to
> another file again later on) -- OK, I don't have such use-case myself.
>


It makes sense to me when used on the save-as dialog, ie keep the old file
open in another tab as well as saving this one under a new filename.  But I
agree it doesn't make sense on rename, but how to know that the user is
going to rename to grey it out?

But neither open in new tab or rename makes sense on the save dialog, its
just that we are too lazy to define different save dialog versions IIUC :)

If save and save-as are to remain the same dialog then only save and cancel
should be sensitive on the save dialog.

Cheers
Lex


>
> So, on this subject, open question: what do other think?  I'm OK with
> the proposed behavior, but as said I could understand somebody wanting
> to keep "open in new tab" with unsaved files;  but if no one cares it
> probably makes the thing more intuitive to remove it (e.g. no unsaved
> file after save).
>
>
> Anyway, the UI should reflect the behavior, e.g. the "Open in new tab"
> checkbox should be sensitive only if it will be used (with your patch,
> when doc->file_name != NULL).
>
> Regards,
> Colomban
>
>
> PS: BTW, please stick to ASCII in commit messages :)
> _______________________________________________
> Devel mailing list
> Devel at lists.geany.org
> https://lists.geany.org/cgi-bin/mailman/listinfo/devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.geany.org/pipermail/devel/attachments/20121106/ea1a76a2/attachment.html>