[Geany-devel] GeanyLua: use of deprecated Scintilla features SCI_SETUSEPALETTE

[Enrico Tröger]

Hi all,

since we obviously don't have a maintainer for GeanyLua, this is
addressed to the list:

GeanyLua wraps the in the latest Scintilla deprecated features
SCI_SETUSEPALETTE and SCI_GETUSEPALETTE.
As far as I could see, there is no further use of these features, just
the wrapper so they could be used in Lua scripts.

Unfortunately, since Scintilla won't define the constants used by
GeanyLua unless compiled with INCLUDE_DEPRECATED_FEATURES defined, this
breaks the build of GeanyLua against Geany from GIT/master (and so the
geany-plugins build as a whole and the nightly builds).


I'd suggest to simply remove those two wrapped functions from GeanyLua.
Though that would mean a hard compatibility break. I guess that it's
probably that simply nobody uses these functions.

However, to be more safe, we could also deprecate these functions in
GeanyLua in some way, so that some sort of migration is possible.


What do you think?

Regards,
Enrico

-- 
Get my GPG key from http://www.uvena.de/pub.asc


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.geany.org/pipermail/devel/attachments/20120708/7222bff4/attachment.pgp>