[Geany-devel] Empty project properties dialog

[Jiří Techet]

On Mon, Jan 9, 2012 at 01:05, Matthew Brush <mbrush at codebrainz.ca> wrote:
> On 12/26/2011 01:37 PM, Jiří Techet wrote:
>>
>> Hi,
>>
>> I'm experiencing a bug where the project properties dialog is empty
>> when opened for the second time. Steps to reproduce:
>>
>> 1. Open project properties dialog.
>> 2. Close it.
>> 3. Open it for the second time.
>>
>> Result: the project properties dialog is much smaller and it's empty.
>>
>> I suspect it's related to the GtkBuiler transition. I haven't looked
>> into it because I guess Matthew knows better what might be wrong.
>>
>
> I fixed this in:
> https://github.com/geany/geany/commit/0755b44db1a238a65d7b3cec7f8b11430c8b2f1e
>
> If you don't mind to test around the project preferences dialog a bit to see
> if you can spot any more problems it would great.

In general it seems to be fixed.

However, there's one related problem - in GProject I add additional
tab to the dialog. At the moment I'm adding the tab every time the
dialog appears because before the GtkBuilder changes the dialog was
destroyed once it was closed. Now it seems you reuse the same dialog
which means I should change the GProject behavior otherwise new and
new GProject tabs are added every time the dialog appears. If this new
behavior is official then the plugins API version should be bumped
because it changes their behavior.

Cheers,

Jiri