[Geany-devel] Patch for Feature Request #3481844

[Colomban Wendling]

Hi,

Le 25/02/2012 23:01, Michael Hall a écrit :
> Attached is a patch to add a Unity Quicklist shortcut for Geany.  The
> patch is from "svn diff".   

Isn't that the same report than in the pull request #27? [1]  No need to
post it twice :)

Though you made me answer your mail so maybe you got what you wanted ^^

> A description of the reasons why and a screenshot of the results can
> both be found in my recent blog post:
> http://mhall119.com/2012/02/contributing-to-unity-for-non-developers-quicklists/

Well, I've a few questions, remarks or criticisms:

1) The name *must* be translatable.  IIRC you just need to prefix the
entry's name with an underscore (_) for intltool to take care of
translating it.

2) Is this a general-purpose change or a patch that only should be in
Ubuntu?  I mean, I don't know of any other distribution using Unity so
I'm not 100% sure this should be applied "upstream"...

2.1) Doesn't GNOME-Shell has something similar that could be made to
also work?  Or does it already?

3) Is the action really useful?  Launching the "geany" command while
Geany is already running already starts a new instance.


Regards,
Colomban


[1] https://github.com/geany/geany/pull/27