[Geany-devel] Maintainerrequest: Geany-Mini-Script

Евгений Аршинов earshinov at xxxxx
Mon Feb 6 13:54:31 UTC 2012


>
> One more thing:
> gms_gui.c:579: error: Possible null pointer dereference: this -
> otherwise it is redundant to check if this is null at line 590
> gms_gui.c:580: error: Possible null pointer dereference: this -
> otherwise it is redundant to check if this is null at line 590
> gms_gui.c:582: error: Possible null pointer dereference: this -
> otherwise it is redundant to check if this is null at line 590
> gms_gui.c:583: error: Possible null pointer dereference: this -
> otherwise it is redundant to check if this is null at line 590
> gms_gui.c:584: error: Possible null pointer dereference: this -
> otherwise it is redundant to check if this is null at line 590
> gms_gui.c:585: error: Possible null pointer dereference: this -
> otherwise it is redundant to check if this is null at line 590
>

Cppcheck doesn't like that in GMS_G_FREE macro called at line 590
there is a check for nullity. I already discovered it earlier and was
going to ask you about it later. Well, I will remove the nullity check
from the macro in 4-5 ours.

The check is indeed redundant since g_free does nothing when a null
pointer is passed. But it breaks simmetry with another macros
(GMS_FREE_WIDGET and another one, I don't remember the name). If
cppcheck complained about one of those macros, that wouldn't be so
easy to fix because nullity check there is actually useful, not
redundant... But it's besides the point.

Sorry for possibly wrong formatting, I'm posting through GMail...



More information about the Devel mailing list