[Geany-devel] Maintainerrequest: Geany-Mini-Script

[Frank Lanitz]

On Sun, 5 Feb 2012 19:37:47 +0400
Eugene Arshinov <earshinov at gmail.com> wrote:

> On Sun, 05 Feb 2012 15:50:54 +0100
> Frank Lanitz <frank at frank.uvena.de> wrote:
> 
> > Am 05.02.2012 12:17, schrieb Eugene Arshinov:
> > > On Sun, 05 Feb 2012 11:53:20 +0100
> > > Frank Lanitz <frank at frank.uvena.de> wrote:
> > > 
> > >> Am 05.02.2012 11:43, schrieb Eugene Arshinov:
> > >>
> > >>> I sent a pull request [1] which contains the plugin integrated
> > >>> into geany-plugins.  Review and pull, if you wish.
> > >>>
> > >>> I also created a repository [2] which contains geany-mini-script
> > >>> plugin at the state in which it was in SVN repo.
> > >>
> > >> Cool. Will you take over maintainership of the code? If so, can
> > >> do also an update on MAINTAINERS?
> > >>
> > > 
> > > Yes, I agree to be the maintainer.  But, in MAINTAINERS file we
> > > specify plugin's web page.  I'd like it to be [1], but the page
> > > can't exist yet.
> > 
> > During the process ... Can you check:
> > 
> > [...]
> > gms_gui.c: In function 'save_prefs_file':
> > gms_gui.c:198:5: warning: too many arguments for format
> > [-Wformat-extra-args]
> > 
> 
> Uhh, sorry for a delay.  I'll check it in 15 minutes.

One more thing: 
gms_gui.c:579: error: Possible null pointer dereference: this -
otherwise it is redundant to check if this is null at line 590
gms_gui.c:580: error: Possible null pointer dereference: this -
otherwise it is redundant to check if this is null at line 590
gms_gui.c:582: error: Possible null pointer dereference: this -
otherwise it is redundant to check if this is null at line 590
gms_gui.c:583: error: Possible null pointer dereference: this -
otherwise it is redundant to check if this is null at line 590
gms_gui.c:584: error: Possible null pointer dereference: this -
otherwise it is redundant to check if this is null at line 590
gms_gui.c:585: error: Possible null pointer dereference: this -
otherwise it is redundant to check if this is null at line 590

Cheers, 
Frank 

-- 
http://frank.uvena.de/en/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20120206/d239a068/attachment.pgp>