[Geany-devel] gtkbuilder branch and ui_lookup_widget functions

[Nick Treleaven]

On 19/10/2011 08:47, Matthew Brush wrote:
> On 11-10-17 05:22 AM, Nick Treleaven wrote:
>> Hi Matthew,
>> I'm a bit concerned about the changed ui_lookup_widget (and hookup)
>> functions - these are in the plugin API and can be used independently
>> from Glade. (plugin) API function behaviour should not normally change,
>> but it seems the owner parameter is now ignored. If we are caching
>> lookups this is probably wrong as the widget may get destroyed.
>>
> OK! I got this more or less fixed up and working like it used to. The
> one exception is some items from the editor menu and maybe a few other
> menu items. I think it's related to some hackery somewhere in the
> existing code that moving around menu items to share the same widgets in
> more than one menu.

IMO it is necessary because there are often popup menu submenus that 
need to be identical, and maintaining duplicate menu items with Glade is 
a pain.

If your code does what Glade 2's interface.c did then I'm not sure why 
there would be incompatibilites.

> I'm hoping someone more familiar with this part of the code can help me
> out here.
>
> You can see the changes here:
>
> https://github.com/codebrainz/geany/commits/gtkbuilder2/
>
> There's still a few FIXME's and it needs to be cleaned up, but if you
> don't mind having a look to see if overall this is fixing the issues you
> raised.

Could you move that branch into the geany repo? It would be easier to 
look at.