[Geany-devel] Geany Plugins Warnings (again)

[Matthew Brush]

Hi,

I know Frank has asked a few times for people to clean up the build 
warnings for their plugins.  There's still *way* too many warnings.

I quickly went through all the warnings and "fixed" them.  I just did 
the quick/obvious fixes and didn't test anything.  I can almost 
guarantee that at least a few of the "fixes" aren't correct and will 
cause problems with the plugins.

Attached are all the patches that fix the warnings.  If the plugins 
developer(s) could each look at their respective patches and review them 
and either apply and thoroughly test their plugins or ignore them and 
otherwise fix the warnings, that would be great.

The only plugin with non-trivial (by way of quantity) warnings to fix 
was GeanyGDB.  I don't know if this is maintained any more or if it's 
needed with having the Debugger plugin, but if it is, the author(s) 
should go through and fix all their `const` usage themselves.  The 
attached patch for GeanyGDB only fixes a few usages but exposes much 
more warnings, so it might be of little use.

In the Treebrowser I did a little more than fix the warnings since there 
were some weird logic and memory issues.  Again, I can't guarantee I've 
fixed them, but it should give some ideas.

For the Gendoc plugin, I'm not sure if the warnings are false positives 
or not, if so, ignore the patch for that.

Just to reiterate *none of the fixes were tested*, so don't just blindly 
apply the patches but rather use them as motivation to fix your plugin 
properly.

Cheers,
Matthew Brush
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-codenav-Cleanup-warnings.patch
Type: text/x-patch
Size: 1554 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20111028/a9c3f910/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-gdb-Partial-cleanup-of-warnings.patch
Type: text/x-patch
Size: 26622 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20111028/a9c3f910/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-gendoc-Cleanup-warnings.patch
Type: text/x-patch
Size: 1612 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20111028/a9c3f910/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-lua-Cleanup-warnings.patch
Type: text/x-patch
Size: 19331 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20111028/a9c3f910/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-macro-Cleanup-warnings.patch
Type: text/x-patch
Size: 1134 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20111028/a9c3f910/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-numberedbookmarks-Cleanup-warnings.patch
Type: text/x-patch
Size: 3635 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20111028/a9c3f910/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-pg-Cleanup-warnings.patch
Type: text/x-patch
Size: 1673 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20111028/a9c3f910/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-prj-Cleanup-warnings.patch
Type: text/x-patch
Size: 1838 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20111028/a9c3f910/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-sendmail-Cleanup-warnings.patch
Type: text/x-patch
Size: 1048 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20111028/a9c3f910/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-vc-Cleanup-warnings.patch
Type: text/x-patch
Size: 4223 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20111028/a9c3f910/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0011-treebrowser-Cleanup-warnings.patch
Type: text/x-patch
Size: 6606 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20111028/a9c3f910/attachment-0010.bin>