[Geany-devel] multiple instance save-settings - Re: Race condition when saving geany.conf

[Enrico Tröger]

On Thu, 20 May 2010 22:52:49 +0400, Eugene wrote:


Hey,

sorry for the delay, I just don't manage to keep up with this stuff :(.


> > > Or, as another option, we can remove automatic saving of
> > > preferences when closing. As preferences are saved immediately
> > > after Preferences dialog is closed, this option wouldn't do any
> > > harm. Or would it?
> > 
> > The historical reason for save on exit was to store window size and
> > position and maybe other things (scribble content, maybe more).
> > So, we still need to save on exit but maybe we can lower the amount
> > of settings we want to save on exit, only those which are really
> > necessary.
> > 
> 
> (this is also a reply to Dimitar)
> 
> Well, then it's not a big deal to only save_dialog_prefs() after the
> Preferences dialog is closed and save everything but dialog prefs (UI
> prefs, session etc.) on exit. That is logical and will solve the
> problem.

Sounds ok to me. But I didn't have a look at the code to find maybe
some potential problems with such a change.

Regards,
Enrico

-- 
Get my GPG key from http://www.uvena.de/pub.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/devel/attachments/20100530/12ae60b6/attachment.pgp>